postgres.git / summary / log / commit / refs

commit    a9a886c6fd9b446866af8d95bc997f6e88496aaa
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Thu May 09 01:29:52 2019 +0000
First released in: 12.0, 9.5.18, 9.6.14, 10.9, 11.4

    Fix error status of vacuumdb when multiple jobs are used
    
    When running a batch of VACUUM or ANALYZE commands on a given database,
    there were cases where it is possible to have vacuumdb not report an
    error where it actually should, leading to incorrect status results.
    
    Author: Julien Rouhaud
    Reviewed-by: Amit Kapila, Michael Paquier
    Discussion: https://postgr.es/m/CAOBaU_ZuTwz7CtqLYJ1Ouuh272bTQPLN8b1bAPk0bCBm4PDMTQ@mail.gmail.com
    Backpatch-through: 9.5


 src/bin/scripts/vacuumdb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/bin/scripts/vacuumdb.c b/src/bin/scripts/vacuumdb.c
index 20dd1d2e601..93728a3a969 100644
--- a/src/bin/scripts/vacuumdb.c
+++ b/src/bin/scripts/vacuumdb.c
@@ -519,7 +519,10 @@ vacuum_one_database(const char *dbname, vacuumingOptions *vacopts,
 		for (j = 0; j < concurrentCons; j++)
 		{
 			if (!GetQueryResult((slots + j)->connection, progname))
+			{
+				failed = true;
 				goto finish;
+			}
 		}
 	}
 


[parent: 44b973b71c95]