postgres.git / summary / log / commit / refs

commit    ab274a1e966516277bf4e75592cb88dc558e2200
Author:   David Rowley <drowley@postgresql.org>
Date:     Tue Sep 29 02:48:44 2026 +0000
First released in: 14.25, 15.20, 16.16, 17.12, 18.7, 19.0

    Fix incorrect calcSumX2 in numeric deserialize functions
    
    calcSumX2 is used to inform the aggregate transition function whether it
    should include the square of the transition value in the aggregate
    state.  The deserialize functions for various numeric aggregates that do
    use calcSumX2 weren't properly setting the property to true.  This does
    not matter in core as we never perform any aggregate transitions after a
    deserialize operation.
    
    This fix is only required for external code which plumbs aggregate paths
    together in such a way that could result in aggregate transitions being
    performed after states have been deserialized.
    
    Author: Maxime Schoemans <maxime.schoemans@enterprisedb.com>
    Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru>
    Discussion: https://postgr.es/m/FEBF5C3D-CC53-455F-AA9D-4D377A2E957C@enterprisedb.com
    Backpatch-through: 14


src/backend/utils/adt/numeric.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/adt/numeric.c b/src/backend/utils/adt/numeric.c index 90d278e0b38..fe9ab741c2a 100644 --- a/src/backend/utils/adt/numeric.c +++ b/src/backend/utils/adt/numeric.c @@ -5368,7 +5368,7 @@ numeric_deserialize(PG_FUNCTION_ARGS) initReadOnlyStringInfo(&buf, VARDATA_ANY(sstate), VARSIZE_ANY_EXHDR(sstate)); - result = makeNumericAggStateCurrentContext(false); + result = makeNumericAggStateCurrentContext(true); /* N */ result->N = pq_getmsgint64(&buf); @@ -5701,7 +5701,7 @@ numeric_poly_deserialize(PG_FUNCTION_ARGS) initReadOnlyStringInfo(&buf, VARDATA_ANY(sstate), VARSIZE_ANY_EXHDR(sstate)); - result = makeInt128AggStateCurrentContext(false); + result = makeInt128AggStateCurrentContext(true); /* N */ result->N = pq_getmsgint64(&buf); [parent: 4331d20f4d5c]