postgres.git / summary / log / commit / refs

commit    acc8cdff424529ce34e93a7ae51eb410b02c7b30
Author:   Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date:     Tue Jul 04 14:57:03 2023 +0000
First released in: 17.0, 11.21, 12.16, 13.12, 14.9, 15.4, 16.0

    Ensure that creation of an empty relfile is fsync'd at checkpoint.
    
    If you create a table and don't insert any data into it, the relation file
    is never fsync'd. You don't lose data, because an empty table doesn't have
    any data to begin with, but if you crash and lose the file, subsequent
    operations on the table will fail with "could not open file" error.
    
    To fix, register an fsync request in mdcreate(), like we do for mdwrite().
    
    Per discussion, we probably should also fsync the containing directory
    after creating a new file. But that's a separate and much wider issue.
    
    Backpatch to all supported versions.
    
    Reviewed-by: Andres Freund, Thomas Munro
    Discussion: https://www.postgresql.org/message-id/d47d8122-415e-425c-d0a2-e0160829702d%40iki.fi


 src/backend/storage/smgr/md.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/backend/storage/smgr/md.c b/src/backend/storage/smgr/md.c
index 51617e17c18..825b58dc416 100644
--- a/src/backend/storage/smgr/md.c
+++ b/src/backend/storage/smgr/md.c
@@ -225,6 +225,9 @@ mdcreate(SMgrRelation reln, ForkNumber forkNum, bool isRedo)
 	mdfd = &reln->md_seg_fds[forkNum][0];
 	mdfd->mdfd_vfd = fd;
 	mdfd->mdfd_segno = 0;
+
+	if (!SmgrIsTemp(reln))
+		register_dirty_segment(reln, forkNum, mdfd);
 }
 
 /*


[parent: 75373ff6c0ef]