postgres.git / summary / log / commit / refs

commit    ad6ffe6a1ffddf19603b13633f054f3d66ef4277
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Sat Sep 05 00:12:53 2026 +0000

    Fix incorrect error message in xlogreader.c
    
    When neither BKPIMAGE_HAS_HOLE nor BKPIMAGE_COMPRESSED is set,
    DecodeXLogRecord() checks that bimg_len needs to be equal to BLCKSZ.
    However, the associated error message reported the data length
    associated to a block (DecodedBkpBlock.data_len), and not the length of
    the block (DecodedBkpBlock.bimg_len).
    
    Oversight in 57aa5b2bb11a, probably due to some copy-paste from the
    surroundings.
    
    Author: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
    Discussion: https://postgr.es/m/CAJTYsWVz9ymE7aMt2ZiQvs1bxNvhjfTf+XaJEsdFw7MT5dvtYQ@mail.gmail.com
    Backpatch-through: 14


 src/backend/access/transam/xlogreader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c
index 6db8dc00e82..d3fbfd6bca8 100644
--- a/src/backend/access/transam/xlogreader.c
+++ b/src/backend/access/transam/xlogreader.c
@@ -1874,7 +1874,7 @@ DecodeXLogRecord(XLogReaderState *state,
 				{
 					report_invalid_record(state,
 										  "neither BKPIMAGE_HAS_HOLE nor BKPIMAGE_COMPRESSED set, but block image length is %u at %X/%X",
-										  (unsigned int) blk->data_len,
+										  (unsigned int) blk->bimg_len,
 										  LSN_FORMAT_ARGS(state->ReadRecPtr));
 					goto err;
 				}


[parent: 4c0a82810fbb]