postgres.git / summary / log / commit / refs

commit    af26f28b9fdd610a7b6dfc5f2d3a2f7b324faa77
Author:   Tatsuo Ishii <ishii@postgresql.org>
Date:     Wed Jun 14 02:11:18 2023 +0000
First released in: 16.0, 15.4

    Fix make_etags breakage on certain platforms.
    
    make_etags produced wrong format TAGS files on platforms such as Mac,
    which uses non-Exuberant ctags.
    
    Author: Masahiko Sawada
    Reviewed-by: Tatsuo Ishii
    Backpatch-through: 15
    Discussion: https://postgr.es/m/CAD21AoDmCqpS%2BU6b9Bc-b4OFx3tz%3DNv6O2KVkoVg7sHk60spjA%40mail.gmail.com


 src/tools/make_ctags | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/tools/make_ctags b/src/tools/make_ctags
index d8d18d1569f..9e952ce916f 100755
--- a/src/tools/make_ctags
+++ b/src/tools/make_ctags
@@ -38,11 +38,10 @@ fi
 find `pwd`/ -type f -name '*.[chyl]' -print |
 	xargs ctags -a -f tags "$FLAGS"
 
-# Exuberant tags has a header that we cannot sort in with the other entries
-# so we skip the sort step
-# Why are we sorting this?  I guess some tag implementation need this,
-# particularly for append mode.  bjm 2012-02-24
-if [ ! "$IS_EXUBERANT" ]
+# Sorting non-Exuberant ctags file allows for fast searching of the tags file.
+# Since etags file has a header that we cannot sort in with the other entries
+# we skip the sort step.
+if [ ! "$IS_EXUBERANT" -a ! "$EMACS_MODE" ]
 then	LC_ALL=C
 	export LC_ALL
 	sort tags >/tmp/$$ && mv /tmp/$$ tags


[parent: cc6974df16e0]