postgres.git / summary / log / commit / refs

commit    b2d69806d8cc902802a7b56ba37fb7c55e58b0ed
Author:   David Rowley <drowley@postgresql.org>
Date:     Mon Jul 01 15:07:15 2019 +0000

    Remove surplus call to table_finish_bulk_insert
    
    4de60244e added the call to table_finish_bulk_insert to the
    CopyMultiInsertBufferCleanup function.  We use a CopyMultiInsertBuffer even
    for non-partitioned tables, so having the cleanup do that meant we would
    call table_finsh_bulk_insert twice when performing COPY FROM with
    a non-partitioned table.
    
    Here we can just remove the direct call in CopyFrom and let
    CopyMultiInsertBufferCleanup handle the call instead.


 src/backend/commands/copy.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c
index c4dfbdacdf3..a4eee4c0d74 100644
--- a/src/backend/commands/copy.c
+++ b/src/backend/commands/copy.c
@@ -3369,8 +3369,6 @@ CopyFrom(CopyState cstate)
 
 	if (insertMethod != CIM_SINGLE)
 	{
-		table_finish_bulk_insert(cstate->rel, ti_options);
-
 		/* Tear down the multi-insert buffer data */
 		CopyMultiInsertInfoCleanup(&multiInsertInfo);
 	}


[parent: 4de60244e2fc]