pgvector.git / summary / log / commit / refs
commit b60e2483a93f6ecb1667f2600c9ad5c3d1da9eff
Author: Andrew Kane <andrew@ankane.org>
Date: Sat Aug 12 21:09:13 2023 +0000
Improved HNSW vacuum stats [skip ci]
src/hnswvacuum.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/hnswvacuum.c b/src/hnswvacuum.c
index 8a0e46e2..f3ae1af3 100644
--- a/src/hnswvacuum.c
+++ b/src/hnswvacuum.c
@@ -32,6 +32,7 @@ RemoveHeapTids(HnswVacuumState * vacuumstate)
Relation index = vacuumstate->index;
BufferAccessStrategy bas = vacuumstate->bas;
HnswElement entryPoint = HnswGetEntryPoint(vacuumstate->index);
+ IndexBulkDeleteResult *stats = vacuumstate->stats;
/* Store separately since highestPoint.level is uint8 */
int highestLevel = -1;
@@ -77,11 +78,15 @@ RemoveHeapTids(HnswVacuumState * vacuumstate)
break;
if (vacuumstate->callback(&etup->heaptids[i], vacuumstate->callback_state))
+ {
itemUpdated = true;
+ stats->tuples_removed++;
+ }
else
{
/* Move to front of list */
etup->heaptids[idx++] = etup->heaptids[i];
+ stats->num_index_tuples++;
}
}
@@ -377,7 +382,6 @@ MarkDeleted(HnswVacuumState * vacuumstate)
BlockNumber insertPage = InvalidBlockNumber;
Relation index = vacuumstate->index;
BufferAccessStrategy bas = vacuumstate->bas;
- IndexBulkDeleteResult *stats = vacuumstate->stats;
while (BlockNumberIsValid(blkno))
{
@@ -431,13 +435,7 @@ MarkDeleted(HnswVacuumState * vacuumstate)
/* Skip live tuples */
if (ItemPointerIsValid(&etup->heaptids[0]))
- {
- stats->num_index_tuples++;
continue;
- }
-
- /* Update stats */
- stats->tuples_removed++;
/* Calculate sizes */
etupSize = HNSW_ELEMENT_TUPLE_SIZE(etup->vec.dim);
[parent: 4295ee3b3ad4]