postgres.git / summary / log / commit / refs

commit    b68f664bb024330d33983b1e1f59f483bdd3aca1
Author:   David Rowley <drowley@postgresql.org>
Date:     Tue Apr 01 22:58:37 2025 +0000

    Fix planner's failure to identify multiple hashable ScalarArrayOpExprs
    
    50e17ad28 (v14) and 29f45e299 (v15) made it so the planner could identify
    IN and NOT IN clauses which have Const lists as right-hand arguments and
    when an appropriate hash function is available for the data types, mark
    the ScalarArrayOpExpr as hashable so the executor could execute it more
    optimally by building and probing a hash table during expression
    evaluation.
    
    These commits both worked correctly when there was only a single
    ScalarArrayOpExpr in the given expression being processed by the
    planner, but when there were multiple, only the first was checked and any
    subsequent ones were not identified, which resulted in less optimal
    expression evaluation during query execution for all but the first found
    ScalarArrayOpExpr.
    
    Backpatch to 14, where 50e17ad28 was introduced.
    
    Author: David Geier <geidav.pg@gmail.com>
    Discussion: https://postgr.es/m/29a76f51-97b0-4c07-87b7-ec8e3b5345c9@gmail.com
    Backpatch-through: 14


 src/backend/optimizer/util/clauses.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/optimizer/util/clauses.c b/src/backend/optimizer/util/clauses.c
index eed6fea624b..02676ce4045 100644
--- a/src/backend/optimizer/util/clauses.c
+++ b/src/backend/optimizer/util/clauses.c
@@ -2228,7 +2228,7 @@ convert_saop_to_hashed_saop_walker(Node *node, void *context)
 				/* Looks good. Fill in the hash functions */
 				saop->hashfuncid = lefthashfunc;
 			}
-			return true;
+			return false;
 		}
 	}
 


[parent: 71790aef1a6e]