postgres.git / summary / log / commit / refs

commit    ba2dbedd539616734bb9c2a6ce74e593a9ee4052
Author:   Fujii Masao <fujii@postgresql.org>
Date:     Tue Jan 14 16:24:24 2025 +0000
First released in: 18.0, 13.19, 14.16, 15.11, 16.7, 17.3

    ecpg: Restore detection of unsupported COPY FROM STDIN.
    
    The ecpg command includes code to warn about unsupported COPY FROM STDIN
    statements in input files. However, since commit 3d009e45bd,
    this functionality has been broken due to a bug introduced in that commit,
    causing ecpg to fail to detect the statement.
    
    This commit resolves the issue, restoring ecpg's ability to detect
    COPY FROM STDIN and issue a warning as intended.
    
    Back-patch to all supported versions.
    
    Author: Ryo Kanbayashi
    Reviewed-by: Hayato Kuroda, Tom Lane
    Discussion: https://postgr.es/m/CANOn0Ez_t5uDCUEV8c1YORMisJiU5wu681eEVZzgKwOeiKhkqQ@mail.gmail.com


 src/interfaces/ecpg/preproc/ecpg.addons | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/interfaces/ecpg/preproc/ecpg.addons b/src/interfaces/ecpg/preproc/ecpg.addons
index e94da2a3f8d..50601554763 100644
--- a/src/interfaces/ecpg/preproc/ecpg.addons
+++ b/src/interfaces/ecpg/preproc/ecpg.addons
@@ -248,7 +248,7 @@ ECPG: where_or_current_clauseWHERECURRENT_POFcursor_name block
 		$$ = cat_str(2,mm_strdup("where current of"), cursor_marker);
 	}
 ECPG: CopyStmtCOPYopt_binaryqualified_nameopt_column_listcopy_fromopt_programcopy_file_namecopy_delimiteropt_withcopy_optionswhere_clause addon
-			if (strcmp($6, "from") == 0 &&
+			if (strcmp($5, "from") == 0 &&
 			   (strcmp($7, "stdin") == 0 || strcmp($7, "stdout") == 0))
 				mmerror(PARSE_ERROR, ET_WARNING, "COPY FROM STDIN is not implemented");
 ECPG: var_valueNumericOnly addon


[parent: 96e61b2792a5]