postgres.git / summary / log / commit / refs

commit    ba61a04bc7fefeee03416d9911eb825c4897c223
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Fri Jan 20 00:52:13 2017 +0000

    Avoid core dump for empty prepared statement in an aborted transaction.
    
    Brown-paper-bag bug in commit ab1f0c822: the old code here coped with
    null CachedPlanSource.raw_parse_tree, the new code not so much.
    Per report from Dave Cramer.
    
    No regression test, because our core testing infrastructure doesn't
    provide any easy way to exercise this path.  Fortunately, the JDBC
    crew test it regularly.
    
    Discussion: https://postgr.es/m/CADK3HH+Ug3xCysKqw_dZOnaNnytZ1Rh5yP05hjO-e4NoyRxVvA@mail.gmail.com


 src/backend/tcop/postgres.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c
index bb89cce8cb9..c15303c7bb4 100644
--- a/src/backend/tcop/postgres.c
+++ b/src/backend/tcop/postgres.c
@@ -1559,7 +1559,8 @@ exec_bind_message(StringInfo input_message)
 	 * functions.
 	 */
 	if (IsAbortedTransactionBlockState() &&
-		(!IsTransactionExitStmt(psrc->raw_parse_tree->stmt) ||
+		(!(psrc->raw_parse_tree &&
+		   IsTransactionExitStmt(psrc->raw_parse_tree->stmt)) ||
 		 numParams != 0))
 		ereport(ERROR,
 				(errcode(ERRCODE_IN_FAILED_SQL_TRANSACTION),


[parent: d479e37e3d20]