postgres.git / summary / log / commit / refs

commit    ba9833a75175fda97ce593fb1f25eb423f5b9b08
Author:   Fujii Masao <fujii@postgresql.org>
Date:     Wed May 20 06:54:13 2026 +0000

    pg_recvlogical: Honor source cluster file permissions for output files
    
    Commit c37b3d08ca6 attempted to preserve group permissions on pg_recvlogical
    output files when group access was enabled on the source cluster. However,
    the output files were still created with a fixed S_IRUSR | S_IWUSR mode,
    preventing group-read permissions from being applied.
    
    This commit fixes the issue by creating output files with pg_file_create_mode
    instead of a hard-coded mode. This allows pg_recvlogical to correctly preserve
    group permissions from the source cluster.
    
    Backpatch to all supported branches.
    
    Author: Fujii Masao <masao.fujii@gmail.com>
    Reviewed-by: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
    Discussion: https://postgr.es/m/CAHGQGwHhpizYzMo3nFP4GkNMueSNMY3QfC-gBN1VTXtuiANDvw@mail.gmail.com
    Backpatch-through: 14


 doc/src/sgml/ref/pg_recvlogical.sgml   | 2 +-
 src/bin/pg_basebackup/pg_recvlogical.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/pg_recvlogical.sgml b/doc/src/sgml/ref/pg_recvlogical.sgml
index fbb1a2be7c8..50c80872e8a 100644
--- a/doc/src/sgml/ref/pg_recvlogical.sgml
+++ b/doc/src/sgml/ref/pg_recvlogical.sgml
@@ -439,7 +439,7 @@ PostgreSQL documentation
 
   <para>
    <application>pg_recvlogical</application> will preserve group permissions on
-   the received WAL files if group permissions are enabled on the source
+   the output files if group permissions are enabled on the source
    cluster.
   </para>
 
diff --git a/src/bin/pg_basebackup/pg_recvlogical.c b/src/bin/pg_basebackup/pg_recvlogical.c
index 02b8e272c37..193adac088e 100644
--- a/src/bin/pg_basebackup/pg_recvlogical.c
+++ b/src/bin/pg_basebackup/pg_recvlogical.c
@@ -329,7 +329,7 @@ StreamLogicalLog(void)
 				outfd = fileno(stdout);
 			else
 				outfd = open(outfile, O_CREAT | O_APPEND | O_WRONLY | PG_BINARY,
-							 S_IRUSR | S_IWUSR);
+							 pg_file_create_mode);
 			if (outfd == -1)
 			{
 				pg_log_error("could not open log file \"%s\": %m", outfile);


[parent: 871d4f5b640c]