postgres.git / summary / log / commit / refs

commit    baacfb9e609cbd7b210225fa25bfc94e518aaabf
Author:   John Naylor <john.naylor@postgresql.org>
Date:     Thu Aug 07 10:15:09 2025 +0000
First released in: 13.22, 14.19, 15.14, 16.10, 17.6, 18.0

    Update ICU C++ API symbols
    
    Recent ICU versions have added U_SHOW_CPLUSPLUS_HEADER_API, and we need
    to set this to zero as well to hide the ICU C++ APIs from pg_locale.h
    
    Per discussion, we want cpluspluscheck to work cleanly in backbranches,
    so backpatch both this and its predecessor commit ed26c4e25a4 to all
    supported versions.
    
    Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
    Discussion: https://postgr.es/m/1115793.1754414782%40sss.pgh.pa.us
    Backpatch-through: 13


 .cirrus.tasks.yml             | 3 ---
 src/include/utils/pg_locale.h | 5 +++++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml
index 995ae7cefb9..3a5cdebf398 100644
--- a/.cirrus.tasks.yml
+++ b/.cirrus.tasks.yml
@@ -581,8 +581,6 @@ task:
   # - Don't use ccache, the files are uncacheable, polluting ccache's
   #   cache
   # - Use -fmax-errors, as particularly cpluspluscheck can be very verbose
-  # - XXX have to disable ICU to avoid errors:
-  #   https://postgr.es/m/20220323002024.f2g6tivduzrktgfa%40alap3.anarazel.de
   # - XXX: the -Wno-register avoids verbose warnings:
   #   https://postgr.es/m/20220308181837.aun3tdtdvao4vb7o%40alap3.anarazel.de
   ###
@@ -590,7 +588,6 @@ task:
     headers_headerscheck_script: |
       time ./configure \
         ${LINUX_CONFIGURE_FEATURES} \
-        --without-icu \
         --quiet \
         CC="gcc" CXX"=g++" CLANG="clang"
       make -s -j${BUILD_JOBS} clean
diff --git a/src/include/utils/pg_locale.h b/src/include/utils/pg_locale.h
index de7c5e30d2d..fef94bc13bc 100644
--- a/src/include/utils/pg_locale.h
+++ b/src/include/utils/pg_locale.h
@@ -16,6 +16,11 @@
 #include <xlocale.h>
 #endif
 #ifdef USE_ICU
+/* only include the C APIs, to avoid errors in cpluspluscheck */
+#undef U_SHOW_CPLUSPLUS_API
+#define U_SHOW_CPLUSPLUS_API 0
+#undef U_SHOW_CPLUSPLUS_HEADER_API
+#define U_SHOW_CPLUSPLUS_HEADER_API 0
 #include <unicode/ucol.h>
 #endif
 


[parent: 63c79a6fc23f]