postgres.git / summary / log / commit / refs

commit    bb8305a654b61e2faaa38dc3d72e09bf0bd6f602
Author:   Andrew Dunstan <andrew@dunslane.net>
Date:     Mon Jul 03 14:06:26 2023 +0000
First released in: 17.0, REL_11_STABLE (reverted before release), REL_12_STABLE (reverted before release), REL_13_STABLE (reverted before release), 14.9, 15.4, 16.0
Reverted by: 4463a78460ee (in 11.21), bec0dcb62963 (in 12.16), 753f20c179f7 (in 13.12)

    Improve pg_basebackup long file name test Windows robustness
    
    Creation of a file with a very long name can create problems on Windows
    due to its file path limits. Work around that by creating the file via a
    symlink with a shorter name.
    
    Error displayed by buildfarm animal fairywren.o
    
    Backpatch to all live branches


src/bin/pg_basebackup/t/010_pg_basebackup.pl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/bin/pg_basebackup/t/010_pg_basebackup.pl b/src/bin/pg_basebackup/t/010_pg_basebackup.pl index 29d0ae0a42c..bc1a78cb7a4 100644 --- a/src/bin/pg_basebackup/t/010_pg_basebackup.pl +++ b/src/bin/pg_basebackup/t/010_pg_basebackup.pl @@ -197,8 +197,12 @@ $node->command_fails( '-T with invalid format fails'); # Tar format doesn't support filenames longer than 100 bytes. +# Create the test file via a short name directory so it doesn't blow the +# Windows path limit. +my $lftmp = PostgreSQL::Test::Utils::tempdir_short; +dir_symlink "$pgdata", "$lftmp/pgdata"; my $superlongname = "superlongname_" . ("x" x 100); -my $superlongpath = "$pgdata/$superlongname"; +my $superlongpath = "$lftmp/pgdata/$superlongname"; open my $file, '>', "$superlongpath" or die "unable to create file $superlongpath"; @@ -206,7 +210,7 @@ close $file; $node->command_fails( [ 'pg_basebackup', '-D', "$tempdir/tarbackup_l1", '-Ft' ], 'pg_basebackup tar with long name fails'); -unlink "$pgdata/$superlongname"; +unlink "$superlongpath"; # The following tests test symlinks. Windows doesn't have symlinks, so # skip on Windows. [parent: 45cfa87e9c56]