postgrespro.git / summary / log / commit / refs

commit    bb874e30fbf9e85bdb117bad34865a5fae29dbf6
Author:   Peter Eisentraut <peter@eisentraut.org>
Date:     Sun Jan 13 09:50:36 2019 +0000

    Make INSTALL makefile rule more robust
    
    With the previous rule, if pandoc was missing, a zero-length output
    file would be created without an error from make.  To improve that,
    write the rule as two separate commands without a pipe.
    
    Reported-by: Tom Lane <tgl@sss.pgh.pa.us>


 doc/src/sgml/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/doc/src/sgml/Makefile b/doc/src/sgml/Makefile
index 93b0b60cdb..8326c7c673 100644
--- a/doc/src/sgml/Makefile
+++ b/doc/src/sgml/Makefile
@@ -103,7 +103,9 @@ ICONV = iconv
 PANDOC = pandoc
 
 INSTALL: % : %.html
-	$(PANDOC) $< -t plain | $(ICONV) -f utf8 -t us-ascii//TRANSLIT > $@
+	$(PANDOC) -t plain -o $@.tmp $<
+	$(ICONV) -f utf8 -t us-ascii//TRANSLIT $@.tmp > $@
+	rm $@.tmp
 
 INSTALL.html: %.html : stylesheet-text.xsl %.xml
 	$(XMLLINT) --noout --valid $*.xml


[parent: 7291733ac93f]