postgres.git / summary / log / commit / refs

commit    be37f270d7646b39155d31b17d9ab66712e07aaf
Author:   Etsuro Fujita <efujita@postgresql.org>
Date:     Fri Feb 27 08:05:02 2026 +0000
First released in: 14.23, 15.18, 16.14, 17.10, 18.4

    postgres_fdw: Fix thinko in comment for UserMappingPasswordRequired().
    
    This commit also rephrases this comment to improve readability.
    
    Oversight in commit 6136e94dc.
    
    Reported-by: Etsuro Fujita <etsuro.fujita@gmail.com>
    Author: Andreas Karlsson <andreas@proxel.se>
    Co-authored-by: Etsuro Fujita <etsuro.fujita@gmail.com>
    Discussion: https://postgr.es/m/CAPmGK16pDnM_wU3kmquPj-M9MYqG3y0BdntRZ0eytqbCaFY3WQ%40mail.gmail.com
    Backpatch-through: 14


 contrib/postgres_fdw/connection.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c
index eb255e74d15..d7acfec9e43 100644
--- a/contrib/postgres_fdw/connection.c
+++ b/contrib/postgres_fdw/connection.c
@@ -660,8 +660,9 @@ disconnect_pg_server(ConnCacheEntry *entry)
 }
 
 /*
- * Return true if the password_required is defined and false for this user
- * mapping, otherwise false. The mapping has been pre-validated.
+ * Check and return the value of password_required, if defined; otherwise,
+ * return true, which is the default value of it.  The mapping has been
+ * pre-validated.
  */
 static bool
 UserMappingPasswordRequired(UserMapping *user)


[parent: 53a57cae1c89]