postgres.git / summary / log / commit / refs

commit    c31305de5f5a4880b0ba2f5983025ef0210a3b2a
Author:   Noah Misch <noah@leadboat.com>
Date:     Sun Mar 23 06:13:43 2014 +0000
First released in: 9.4.0, 9.2.9, 9.3.5

    Address ccvalid/ccnoinherit in TupleDesc support functions.
    
    equalTupleDescs() neglected both of these ConstrCheck fields, and
    CreateTupleDescCopyConstr() neglected ccnoinherit.  At this time, the
    only known behavior defect resulting from these omissions is constraint
    exclusion disregarding a CHECK constraint validated by an ALTER TABLE
    VALIDATE CONSTRAINT statement issued earlier in the same transaction.
    Back-patch to 9.2, where these fields were introduced.


 src/backend/access/common/tupdesc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/backend/access/common/tupdesc.c b/src/backend/access/common/tupdesc.c
index db8cb822724..74cfb6499a5 100644
--- a/src/backend/access/common/tupdesc.c
+++ b/src/backend/access/common/tupdesc.c
@@ -204,6 +204,7 @@ CreateTupleDescCopyConstr(TupleDesc tupdesc)
 				if (constr->check[i].ccbin)
 					cpy->check[i].ccbin = pstrdup(constr->check[i].ccbin);
 				cpy->check[i].ccvalid = constr->check[i].ccvalid;
+				cpy->check[i].ccnoinherit = constr->check[i].ccnoinherit;
 			}
 		}
 
@@ -458,7 +459,9 @@ equalTupleDescs(TupleDesc tupdesc1, TupleDesc tupdesc2)
 			for (j = 0; j < n; check2++, j++)
 			{
 				if (strcmp(check1->ccname, check2->ccname) == 0 &&
-					strcmp(check1->ccbin, check2->ccbin) == 0)
+					strcmp(check1->ccbin, check2->ccbin) == 0 &&
+					check1->ccvalid == check2->ccvalid &&
+					check1->ccnoinherit == check2->ccnoinherit)
 					break;
 			}
 			if (j >= n)


[parent: 4c0e97c2d58f]