postgres.git / summary / log / commit / refs

commit    c42f2bdcdf7f3ca765b1dc5ba5753e9f8b545e85
Author:   Andres Freund <andres@anarazel.de>
Date:     Wed Aug 13 19:52:54 2025 +0000
First released in: 16.11, 17.7, 18.0

    ci: windows: Stop using DEBUG:FASTLINK
    
    Currently the pdb file for libpq and some other libraries are named the same
    for the static and shared libraries. That has been the case for a long time,
    but recently started failing, after an image update started using a newer
    ninja version. The issue is not itself caused by ninja, but just made visible,
    as the newer version optimizes the build order and builds the shared libpq
    earlier than the static library. Previously both static and shared libraries
    were built at the same time, which prevented msvc from detecting the issue.
    
    When using /DEBUG:FASTLINK pdb files cannot be updated, triggering the error.
    
    We were using /DEBUG:FASTLINK due to running out of memory in the past, but
    that was when using container based CI images, rather than full VMs.
    
    This isn't really the correct fix (that'd be to deconflict the pdb file
    names), but we'd like to get CI to become green again, and a proper fix (in
    meson) will presumably take longer.
    
    Suggested-by: Andres Freund <andres@anarazel.de>
    Author: Nazir Bilal Yavuz <byavuz81@gmail.com>
    Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com>
    Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
    Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
    Discussion: https://postgr.es/m/CAN55FZ1RuBhJmPWs3Oi%3D9UoezDfrtO-VaU67db5%2B0_uy19uF%2BA%40mail.gmail.com
    Backpatch-through: 16


 .cirrus.tasks.yml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml
index aa01f57202c..45e9e35428e 100644
--- a/.cirrus.tasks.yml
+++ b/.cirrus.tasks.yml
@@ -567,10 +567,9 @@ task:
     echo 127.0.0.3 pg-loadbalancetest >> c:\Windows\System32\Drivers\etc\hosts
     type c:\Windows\System32\Drivers\etc\hosts
 
-  # Use /DEBUG:FASTLINK to avoid high memory usage during linking
   configure_script: |
     vcvarsall x64
-    meson setup --backend ninja --buildtype debug -Dc_link_args=/DEBUG:FASTLINK -Dcassert=true -Db_pch=true -Dextra_lib_dirs=c:\openssl\1.1\lib -Dextra_include_dirs=c:\openssl\1.1\include -DTAR=%TAR% -DPG_TEST_EXTRA="%PG_TEST_EXTRA%" build
+    meson setup --backend ninja --buildtype debug -Dcassert=true -Db_pch=true -Dextra_lib_dirs=c:\openssl\1.1\lib -Dextra_include_dirs=c:\openssl\1.1\include -DTAR=%TAR% -DPG_TEST_EXTRA="%PG_TEST_EXTRA%" build
 
   build_script: |
     vcvarsall x64


[parent: e67d5f7baa7d]