postgres.git / summary / log / commit / refs

commit    c4b0edb07ed53063ea4c86cd7918ad6ea01d8979
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Thu Feb 27 12:58:37 2020 +0000

    Remove TAP test for createdb --lc-ctype
    
    OpenBSD falls back to "C" when using an incorrect input with setlocale()
    and LC_CTYPE, causing this test, introduced by 008cf04, to fail.  This
    removes the culprit test to avoid the portability issue.
    
    Per report from Robert Haas, via buildfarm member curculio.
    
    Discussion: https://postgr.es/m/CA+TgmoZ6ddh3mHD9gU8DvNYoFmuJaYYn1+4AvZNp25vTdRwCAQ@mail.gmail.com
    Backpatch-through: 11


 src/bin/scripts/t/020_createdb.pl | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/bin/scripts/t/020_createdb.pl b/src/bin/scripts/t/020_createdb.pl
index d94d4edd901..89de674265a 100644
--- a/src/bin/scripts/t/020_createdb.pl
+++ b/src/bin/scripts/t/020_createdb.pl
@@ -3,7 +3,7 @@ use warnings;
 
 use PostgresNode;
 use TestLib;
-use Test::More tests => 22;
+use Test::More tests => 19;
 
 program_help_ok('createdb');
 program_version_ok('createdb');
@@ -40,11 +40,3 @@ $node->command_checks_all(
 		qr/^createdb: error: database creation failed: ERROR:  invalid locale name/s
 	],
 	'createdb with incorrect --lc-collate');
-$node->command_checks_all(
-	[ 'createdb', '--lc-ctype', "foo'; SELECT '1", 'foobar2' ],
-	1,
-	[qr/^$/],
-	[
-		qr/^createdb: error: database creation failed: ERROR:  invalid locale name/s
-	],
-	'createdb with incorrect --lc-ctype');


[parent: 428a2609ef64]