postgres.git / summary / log / commit / refs

commit    c59278a1aa5ef2ee8a6d5d83bd987a7ce5c89e84
Author:   Peter Geoghegan <pg@bowt.ie>
Date:     Wed Nov 03 02:52:11 2021 +0000
First released in: 15.0, 14.1

    Fix parallel amvacuumcleanup safety bug.
    
    Commit b4af70cb inverted the return value of the function
    parallel_processing_is_safe(), but missed the amvacuumcleanup test.
    Index AMs that don't support parallel cleanup at all were affected.
    
    The practical consequences of this bug were not very serious.  Hash
    indexes are affected, but since they just return the number of blocks
    during hashvacuumcleanup anyway, it can't have had much impact.
    
    Author: Masahiko Sawada <sawada.mshk@gmail.com>
    Discussion: https://postgr.es/m/CAD21AoA-Em+aeVPmBbL_s1V-ghsJQSxYL-i3JP8nTfPiD1wjKw@mail.gmail.com
    Backpatch: 14-, where commit b4af70cb appears.


 src/backend/access/heap/vacuumlazy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c
index bfb1ea0d25f..716af22e5b3 100644
--- a/src/backend/access/heap/vacuumlazy.c
+++ b/src/backend/access/heap/vacuumlazy.c
@@ -4116,7 +4116,7 @@ parallel_processing_is_safe(Relation indrel, LVShared *lvshared)
 		/* Skip, if the index does not support parallel cleanup */
 		if (((vacoptions & VACUUM_OPTION_PARALLEL_CLEANUP) == 0) &&
 			((vacoptions & VACUUM_OPTION_PARALLEL_COND_CLEANUP) == 0))
-			return true;
+			return false;
 
 		/*
 		 * Skip, if the index supports parallel cleanup conditionally, but we


[parent: 24f9e49e430b]