postgres.git / summary / log / commit / refs
commit c5af141cd4344d52ad8afbd6ecffe509227559a9
Author: David Rowley <drowley@postgresql.org>
Date: Tue Jan 06 01:39:36 2026 +0000
Clarify where various catcache.h dlist_nodes are used
Also remove a comment which mentions we don't currently divide the
per-cache lists into hash buckets. Since 473182c95, we do.
Author: ChangAo Chen <cca5507@qq.com>
Discussion: https://postgr.es/m/tencent_7732789707C8768EA13785A7B5EA29103208@qq.com
src/include/utils/catcache.h | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/include/utils/catcache.h b/src/include/utils/catcache.h
index a12f8a1a40a..a28a1e483eb 100644
--- a/src/include/utils/catcache.h
+++ b/src/include/utils/catcache.h
@@ -93,7 +93,7 @@ typedef struct catctup
* lookups. Keep the dlist_node field first so that Valgrind understands
* the struct is reachable.
*/
- dlist_node cache_elem; /* list member of per-bucket list */
+ dlist_node cache_elem; /* member for CatCache.cc_bucket[] dlist */
int ct_magic; /* for identifying CatCTup entries */
#define CT_MAGIC 0x57261502
@@ -144,9 +144,6 @@ typedef struct catctup
* object contains links to cache entries for all the table rows satisfying
* the partial key. (Note: none of these will be negative cache entries.)
*
- * A CatCList is only a member of a per-cache list; we do not currently
- * divide them into hash buckets.
- *
* A list marked "dead" must not be returned by subsequent searches.
* However, it won't be physically deleted from the cache until its
* refcount goes to zero. (A list should be marked dead if any of its
@@ -163,7 +160,7 @@ typedef struct catclist
* Keep the dlist_node field first so that Valgrind understands the struct
* is reachable.
*/
- dlist_node cache_elem; /* list member of per-catcache list */
+ dlist_node cache_elem; /* member for CatCache.cc_lbucket[] dlist */
int cl_magic; /* for identifying CatCList entries */
#define CL_MAGIC 0x52765103
[parent: e212a0f8e6ba]