postgres.git / summary / log / commit / refs

commit    c5b15c417140b2b18b590d201b2fdb7b587214fd
Author:   Andrew Dunstan <andrew@dunslane.net>
Date:     Fri Jul 12 22:29:15 2024 +0000

    Make sure to run pg_isready on correct port
    
    The current code can have pg_isready unexpectedly succeed if there is a
    server running on the default port. To avoid this we delay running the
    test until after a node has been created but before it starts, and then
    use that node's port, so we are fairly sure there is nothing running on
    the port.
    
    Backpatch to all live branches.


 src/bin/scripts/t/080_pg_isready.pl | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/bin/scripts/t/080_pg_isready.pl b/src/bin/scripts/t/080_pg_isready.pl
index 375f0feb216..f6f3d796825 100644
--- a/src/bin/scripts/t/080_pg_isready.pl
+++ b/src/bin/scripts/t/080_pg_isready.pl
@@ -12,10 +12,11 @@ program_help_ok('pg_isready');
 program_version_ok('pg_isready');
 program_options_handling_ok('pg_isready');
 
-command_fails(['pg_isready'], 'fails with no server running');
-
 my $node = get_new_node('main');
 $node->init;
+
+$node->command_fails(['pg_isready'], 'fails with no server running');
+
 $node->start;
 
 $node->command_ok(


[parent: 894b497ac91d]