postgres.git / summary / log / commit / refs

commit    c8b21b0378141948a2dc0ddde6f57407321787ea
Author:   Amit Kapila <akapila@postgresql.org>
Date:     Fri Feb 12 04:41:16 2021 +0000
First released in: 14.0

    Fix Subscription test added by commit ce0fdbfe97.
    
    We want to test the variants of Alter Subscription that are not allowed in
    the transaction block but for that, we don't need to create a subscription
    that tries to connect to the publisher. As such, there is no problem with
    this test but it is good to allow such tests to run with
    wal_level = minimal and max_wal_senders = 0 so as to keep them consistent
    with other tests.
    
    Reported by buildfarm.
    
    Author: Amit Kapila
    Reviewed-by: Ajin Cherian
    Discussion: https://postgr.es/m/CAA4eK1Lw0V+e1JPGHDq=+hVACv=14H8sR+2eJ1k3PEgwKmU-jQ@mail.gmail.com


 src/test/regress/expected/subscription.out | 6 ++++--
 src/test/regress/sql/subscription.sql      | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/test/regress/expected/subscription.out b/src/test/regress/expected/subscription.out
index 7802279cb2e..14a430221d6 100644
--- a/src/test/regress/expected/subscription.out
+++ b/src/test/regress/expected/subscription.out
@@ -201,8 +201,10 @@ ALTER SUBSCRIPTION regress_testsub SET (slot_name = NONE);
 (1 row)
 
 DROP SUBSCRIPTION regress_testsub;
-CREATE SUBSCRIPTION regress_testsub CONNECTION 'dbname=postgres' PUBLICATION mypub
-       WITH (enabled = true, create_slot = false, copy_data = false);
+CREATE SUBSCRIPTION regress_testsub CONNECTION 'dbname=regress_doesnotexist' PUBLICATION mypub
+       WITH (connect = false, create_slot = false, copy_data = false);
+WARNING:  tables were not subscribed, you will have to run ALTER SUBSCRIPTION ... REFRESH PUBLICATION to subscribe the tables
+ALTER SUBSCRIPTION regress_testsub ENABLE;
 -- fail - ALTER SUBSCRIPTION with refresh is not allowed in a transaction
 -- block or function
 BEGIN;
diff --git a/src/test/regress/sql/subscription.sql b/src/test/regress/sql/subscription.sql
index ca0d7827429..81e65e5e642 100644
--- a/src/test/regress/sql/subscription.sql
+++ b/src/test/regress/sql/subscription.sql
@@ -147,8 +147,10 @@ ALTER SUBSCRIPTION regress_testsub SET (slot_name = NONE);
 
 DROP SUBSCRIPTION regress_testsub;
 
-CREATE SUBSCRIPTION regress_testsub CONNECTION 'dbname=postgres' PUBLICATION mypub
-       WITH (enabled = true, create_slot = false, copy_data = false);
+CREATE SUBSCRIPTION regress_testsub CONNECTION 'dbname=regress_doesnotexist' PUBLICATION mypub
+       WITH (connect = false, create_slot = false, copy_data = false);
+
+ALTER SUBSCRIPTION regress_testsub ENABLE;
 
 -- fail - ALTER SUBSCRIPTION with refresh is not allowed in a transaction
 -- block or function


[parent: ce0fdbfe9722]