postgres.git / summary / log / commit / refs

commit    c8e993503d0f1a0cb8f187a136fb64cead9ba591
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Fri Mar 25 22:44:47 2011 +0000
First released in: 9.1.0

    Fix failure to propagate collation in negate_clause().
    
    Turns out it was this, and not so much plpgsql, that was at fault in Stefan
    Huehner's collation-error-in-a-trigger bug report of a couple weeks ago.


 src/backend/optimizer/prep/prepqual.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/backend/optimizer/prep/prepqual.c b/src/backend/optimizer/prep/prepqual.c
index fbd68097244..10e00d90dda 100644
--- a/src/backend/optimizer/prep/prepqual.c
+++ b/src/backend/optimizer/prep/prepqual.c
@@ -104,6 +104,8 @@ negate_clause(Node *node)
 					newopexpr->opfuncid = InvalidOid;
 					newopexpr->opresulttype = opexpr->opresulttype;
 					newopexpr->opretset = opexpr->opretset;
+					newopexpr->opcollid = opexpr->opcollid;
+					newopexpr->inputcollid = opexpr->inputcollid;
 					newopexpr->args = opexpr->args;
 					newopexpr->location = opexpr->location;
 					return (Node *) newopexpr;
@@ -126,6 +128,7 @@ negate_clause(Node *node)
 					newopexpr->opno = negator;
 					newopexpr->opfuncid = InvalidOid;
 					newopexpr->useOr = !saopexpr->useOr;
+					newopexpr->inputcollid = saopexpr->inputcollid;
 					newopexpr->args = saopexpr->args;
 					newopexpr->location = saopexpr->location;
 					return (Node *) newopexpr;


[parent: 9b19c12e1d93]