postgres.git / summary / log / commit / refs

commit    c9dacdb1c9428c2a021ee4d0a444147f8fcf07ef
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Tue Aug 07 19:43:49 2018 +0000

    Fix pg_upgrade to handle event triggers in extensions correctly.
    
    pg_dump with --binary-upgrade must emit ALTER EXTENSION ADD commands
    for all objects that are members of extensions.  It forgot to do so for
    event triggers, as per bug #15310 from Nick Barnes.  Back-patch to 9.3
    where event triggers were introduced.
    
    Haribabu Kommi
    
    Discussion: https://postgr.es/m/153360083872.1395.4593932457718151600@wrigleys.postgresql.org


 src/bin/pg_dump/pg_dump.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 8080155a957..542f9e950de 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -16660,6 +16660,10 @@ dumpEventTrigger(Archive *fout, EventTriggerInfo *evtinfo)
 	appendPQExpBuffer(delqry, "DROP EVENT TRIGGER %s;\n",
 					  qevtname);
 
+	if (dopt->binary_upgrade)
+		binary_upgrade_extension_member(query, &evtinfo->dobj,
+										"EVENT TRIGGER", qevtname, NULL);
+
 	if (evtinfo->dobj.dump & DUMP_COMPONENT_DEFINITION)
 		ArchiveEntry(fout, evtinfo->dobj.catId, evtinfo->dobj.dumpId,
 					 evtinfo->dobj.name, NULL, NULL,


[parent: dc391dacf170]