postgres.git / summary / log / commit / refs

commit    cc609c46fbf0d0e8a7995207c07286c6248eb732
Author:   Kevin Grittner <kgrittn@postgresql.org>
Date:     Fri Jan 30 15:01:36 2015 +0000
First released in: 9.5.0, 9.3.6, 9.4.1

    Allow pg_dump to use jobs and serializable transactions together.
    
    Since 9.3, when the --jobs option was introduced, using it together
    with the --serializable-deferrable option generated multiple
    errors.  We can get correct behavior by allowing the connection
    which acquires the snapshot to use SERIALIZABLE, READ ONLY,
    DEFERRABLE and pass that to the workers running the other
    connections using REPEATABLE READ, READ ONLY.  This is a bit of a
    kluge since the SERIALIZABLE behavior is achieved by running some
    of the participating connections at a different isolation level,
    but it is a simple and safe change, suitable for back-patching.
    
    This will be followed by a proposal for a more invasive fix with
    some slight behavioral changes on just the master branch, based on
    suggestions from Andres Freund, but the kluge will be applied to
    master until something is agreed along those lines.
    
    Back-patched to 9.3, where the --jobs option was added.
    
    Based on report from Alexander Korotkov


src/bin/pg_dump/pg_dump.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index 84344b45aef..122df375493 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -1004,7 +1004,15 @@ setup_connection(Archive *AH, const char *dumpencoding, char *use_role) ExecuteSqlStatement(AH, "BEGIN"); if (AH->remoteVersion >= 90100) { - if (serializable_deferrable) + /* + * To support the combination of serializable_deferrable with the jobs + * option we use REPEATABLE READ for the worker connections that are + * passed a snapshot. As long as the snapshot is acquired in a + * SERIALIZABLE, READ ONLY, DEFERRABLE transaction, its use within a + * REPEATABLE READ transaction provides the appropriate integrity + * guarantees. This is a kluge, but safe for back-patching. + */ + if (serializable_deferrable && AH->sync_snapshot_id == NULL) ExecuteSqlStatement(AH, "SET TRANSACTION ISOLATION LEVEL " "SERIALIZABLE, READ ONLY, DEFERRABLE"); [parent: 39c46c5f28b2]