pgvector.git / summary / log / commit / refs

commit    ceeba6a134bc3a24a298b706e5b28967f7ea708f
Author:   Andrew Kane <andrew@ankane.org>
Date:     Mon Apr 15 21:11:17 2024 +0000

    Added todo [skip ci]


src/sparsevec.c | 2 ++ test/expected/sparsevec_functions.out | 6 ++++++ test/sql/sparsevec_functions.sql | 1 + 3 files changed, 9 insertions(+) diff --git a/src/sparsevec.c b/src/sparsevec.c index 6011d92f..5bed3ff2 100644 --- a/src/sparsevec.c +++ b/src/sparsevec.c @@ -876,6 +876,8 @@ sparsevec_l2_normalize(PG_FUNCTION_ARGS) for (int i = 0; i < a->nnz; i++) { result->indices[i] = a->indices[i]; + + /* TODO Remove zeros */ rx[i] = ax[i] / norm; } diff --git a/test/expected/sparsevec_functions.out b/test/expected/sparsevec_functions.out index afa02507..e6af3c9e 100644 --- a/test/expected/sparsevec_functions.out +++ b/test/expected/sparsevec_functions.out @@ -322,3 +322,9 @@ SELECT l2_normalize('{1:3e38}/1'::sparsevec); {1:1}/1 (1 row) +SELECT l2_normalize('{1:3e38,2:1e-37}/2'::sparsevec); + l2_normalize +-------------- + {1:1,2:0}/2 +(1 row) + diff --git a/test/sql/sparsevec_functions.sql b/test/sql/sparsevec_functions.sql index d260dbd6..e8600678 100644 --- a/test/sql/sparsevec_functions.sql +++ b/test/sql/sparsevec_functions.sql @@ -61,3 +61,4 @@ SELECT l2_normalize('{1:3}/2'::sparsevec); SELECT l2_normalize('{2:0.1}/2'::sparsevec); SELECT l2_normalize('{}/2'::sparsevec); SELECT l2_normalize('{1:3e38}/1'::sparsevec); +SELECT l2_normalize('{1:3e38,2:1e-37}/2'::sparsevec); [parent: 127ecdd65060]