pgbackrest.git / summary / log / commit / refs
commit cfb8aa202ee972579697db2cc8d5d8ef111f0022
Author: David Steele <david@pgmasters.net>
Date: Fri Jun 21 05:29:17 2024 +0000
Add remote locks for stanza commands missed in 31c7824a.
31c7824a should have added remote locks when the commands were modified to run remotely. This is unlikely to have caused issues since these commands are generally not run concurrently with backup/expire but having the locks is safer.
doc/xml/release/2024/2.53.xml | 5 ++++-
src/build/config/config.yaml | 3 +++
src/config/parse.auto.c.inc | 3 +++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/doc/xml/release/2024/2.53.xml b/doc/xml/release/2024/2.53.xml
index cfc0e9a46..5af191f8a 100644
--- a/doc/xml/release/2024/2.53.xml
+++ b/doc/xml/release/2024/2.53.xml
@@ -30,7 +30,10 @@
<release-development-list>
<release-item>
- <github-pull-request id="2371"/>
+ <commit subject="Refactor lock module.">
+ <github-pull-request id="2371"/>
+ </commit>
+ <commit subject="Add remote locks for stanza commands missed in 31c7824a."/>
<release-item-contributor-list>
<release-item-contributor id="david.steele"/>
diff --git a/src/build/config/config.yaml b/src/build/config/config.yaml
index bd3fbac8f..22cdcfe3a 100644
--- a/src/build/config/config.yaml
+++ b/src/build/config/config.yaml
@@ -143,18 +143,21 @@ command:
stanza-create:
command-role:
remote: {}
+ lock-remote-required: true
lock-required: true
lock-type: all
stanza-delete:
command-role:
remote: {}
+ lock-remote-required: true
lock-required: true
lock-type: all
stanza-upgrade:
command-role:
remote: {}
+ lock-remote-required: true
lock-required: true
lock-type: all
diff --git a/src/config/parse.auto.c.inc b/src/config/parse.auto.c.inc
index f20b353ed..4db66af29 100644
--- a/src/config/parse.auto.c.inc
+++ b/src/config/parse.auto.c.inc
@@ -595,6 +595,7 @@ static const ParseRuleCommand parseRuleCommand[CFG_COMMAND_TOTAL] =
( // cmd/stanza-create
PARSE_RULE_COMMAND_NAME("stanza-create"), // cmd/stanza-create
PARSE_RULE_COMMAND_LOCK_REQUIRED(true), // cmd/stanza-create
+ PARSE_RULE_COMMAND_LOCK_REMOTE_REQUIRED(true), // cmd/stanza-create
PARSE_RULE_COMMAND_LOCK_TYPE(lockTypeAll), // cmd/stanza-create
PARSE_RULE_COMMAND_LOG_FILE(true), // cmd/stanza-create
PARSE_RULE_COMMAND_LOG_LEVEL_DEFAULT(logLevelInfo), // cmd/stanza-create
@@ -610,6 +611,7 @@ static const ParseRuleCommand parseRuleCommand[CFG_COMMAND_TOTAL] =
( // cmd/stanza-delete
PARSE_RULE_COMMAND_NAME("stanza-delete"), // cmd/stanza-delete
PARSE_RULE_COMMAND_LOCK_REQUIRED(true), // cmd/stanza-delete
+ PARSE_RULE_COMMAND_LOCK_REMOTE_REQUIRED(true), // cmd/stanza-delete
PARSE_RULE_COMMAND_LOCK_TYPE(lockTypeAll), // cmd/stanza-delete
PARSE_RULE_COMMAND_LOG_FILE(true), // cmd/stanza-delete
PARSE_RULE_COMMAND_LOG_LEVEL_DEFAULT(logLevelInfo), // cmd/stanza-delete
@@ -625,6 +627,7 @@ static const ParseRuleCommand parseRuleCommand[CFG_COMMAND_TOTAL] =
( // cmd/stanza-upgrade
PARSE_RULE_COMMAND_NAME("stanza-upgrade"), // cmd/stanza-upgrade
PARSE_RULE_COMMAND_LOCK_REQUIRED(true), // cmd/stanza-upgrade
+ PARSE_RULE_COMMAND_LOCK_REMOTE_REQUIRED(true), // cmd/stanza-upgrade
PARSE_RULE_COMMAND_LOCK_TYPE(lockTypeAll), // cmd/stanza-upgrade
PARSE_RULE_COMMAND_LOG_FILE(true), // cmd/stanza-upgrade
PARSE_RULE_COMMAND_LOG_LEVEL_DEFAULT(logLevelInfo), // cmd/stanza-upgrade
[parent: b9a9ef2d5fa2]