postgres.git / summary / log / commit / refs

commit    d2a1ed1727a8ef45eab1a8ddb3d375c1ce839aac
Author:   Daniel Gustafsson <dgustafsson@postgresql.org>
Date:     Wed Apr 30 08:34:08 2025 +0000
First released in: master (reverted before release)
Reverted by: fb844b9f0656 (in 18.0)

    Add missing string terminator
    
    When copying the string strncpy won't add nul termination since
    the string length is equal to the length specified.  Explicitly
    set a nul terminator after copying to properly terminate. Found
    via post-commit review.
    
    Author: Rahila Syed <rahilasyed90@gmail.com>
    Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
    Discussion: https://postgr.es/m/CAH2L28vt16C9xTuK+K7QZvtA3kCNWXOEiT=gEekUw3Xxp9LVQw@mail.gmail.com


 src/backend/utils/mmgr/mcxt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/backend/utils/mmgr/mcxt.c b/src/backend/utils/mmgr/mcxt.c
index 506f2902986..786e92039b1 100644
--- a/src/backend/utils/mmgr/mcxt.c
+++ b/src/backend/utils/mmgr/mcxt.c
@@ -1663,6 +1663,7 @@ ProcessGetMemoryContextInterrupt(void)
 			meminfo[max_stats - 1].name = dsa_allocate(MemoryStatsDsaArea, namelen + 1);
 			nameptr = dsa_get_address(MemoryStatsDsaArea, meminfo[max_stats - 1].name);
 			strncpy(nameptr, "Remaining Totals", namelen);
+			nameptr[namelen] = '\0';
 			meminfo[max_stats - 1].ident = InvalidDsaPointer;
 			meminfo[max_stats - 1].path = InvalidDsaPointer;
 			meminfo[max_stats - 1].type = 0;


[parent: 991407ae8678]