postgres.git / summary / log / commit / refs

commit    d412f79381935186dc8f95fd2dc30227a82f012f
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Tue Jun 20 21:06:43 2017 +0000
First released in: 10.0

    Make opr_sanity test complain about built-in functions marked prosecdef.
    
    Currently, there are no built-in functions that are SECURITY DEFINER.
    But we just found an instance where one was mistakenly marked that way,
    so it seems prudent to add a test about it.  If we ever grow some
    functions that are intentionally SECURITY DEFINER, we can alter the
    expected output of this test, or adjust the query to filter out functions
    for which it's okay.
    
    Per suggestion from Robert Haas.
    
    Discussion: https://postgr.es/m/CA+TgmoYXg7McY33+jbWmG=rS-HNUur0S6W8Q8kVNFf7epFimVA@mail.gmail.com


 src/test/regress/expected/opr_sanity.out | 10 ++++++++++
 src/test/regress/sql/opr_sanity.sql      |  7 +++++++
 2 files changed, 17 insertions(+)

diff --git a/src/test/regress/expected/opr_sanity.out b/src/test/regress/expected/opr_sanity.out
index 1d7629f84ee..fcf8bd75659 100644
--- a/src/test/regress/expected/opr_sanity.out
+++ b/src/test/regress/expected/opr_sanity.out
@@ -96,6 +96,16 @@ WHERE proiswindow AND (proisagg OR proretset);
 -----+---------
 (0 rows)
 
+-- currently, no built-in functions should be SECURITY DEFINER;
+-- this might change in future, but there will probably never be many.
+SELECT p1.oid, p1.proname
+FROM pg_proc AS p1
+WHERE prosecdef
+ORDER BY 1;
+ oid | proname 
+-----+---------
+(0 rows)
+
 -- pronargdefaults should be 0 iff proargdefaults is null
 SELECT p1.oid, p1.proname
 FROM pg_proc AS p1
diff --git a/src/test/regress/sql/opr_sanity.sql b/src/test/regress/sql/opr_sanity.sql
index bf2edb5d993..2945966c0e4 100644
--- a/src/test/regress/sql/opr_sanity.sql
+++ b/src/test/regress/sql/opr_sanity.sql
@@ -95,6 +95,13 @@ SELECT p1.oid, p1.proname
 FROM pg_proc AS p1
 WHERE proiswindow AND (proisagg OR proretset);
 
+-- currently, no built-in functions should be SECURITY DEFINER;
+-- this might change in future, but there will probably never be many.
+SELECT p1.oid, p1.proname
+FROM pg_proc AS p1
+WHERE prosecdef
+ORDER BY 1;
+
 -- pronargdefaults should be 0 iff proargdefaults is null
 SELECT p1.oid, p1.proname
 FROM pg_proc AS p1


[parent: 15c91568cfa4]