postgres.git / summary / log / commit / refs

commit    d4d4e95030f2c808e1cc85404959145e37db42ba
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Sun Nov 29 21:02:34 2009 +0000
First released in: 9.0.0, 8.2.15, 8.3.9, 8.4.2

    Fix session-lifespan memory leak when a plperl function is redefined:
    we have to tell Perl it can release its compiled copy of the function
    text.  Noted by Alexey Klyukin.
    
    Back-patch to 8.2 --- the problem exists further back, but this patch
    won't work without modification, and it's probably not worth the trouble.


 src/pl/plperl/plperl.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
index 0954098dfaf..4fed6ee8b51 100644
--- a/src/pl/plperl/plperl.c
+++ b/src/pl/plperl/plperl.c
@@ -1,7 +1,7 @@
 /**********************************************************************
  * plperl.c - perl as a procedural language for PostgreSQL
  *
- *	  $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.123.2.8 2009/10/31 18:12:20 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.123.2.9 2009/11/29 21:02:34 tgl Exp $
  *
  **********************************************************************/
 
@@ -1502,10 +1502,13 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
 
 		if (!uptodate)
 		{
-			free(prodesc); /* are we leaking memory here? */
-			prodesc = NULL;
 			hash_search(plperl_proc_hash, internal_proname,
-						HASH_REMOVE,NULL);
+						HASH_REMOVE, NULL);
+			if (prodesc->reference)
+				SvREFCNT_dec(prodesc->reference);
+			free(prodesc->proname);
+			free(prodesc);
+			prodesc = NULL;
 		}
 	}
 


[parent: 26a13b72421f]