postgres.git / summary / log / commit / refs

commit    d5f4df7264ec73abda41eb78b81cf430b33f7606
Author:   Fujii Masao <fujii@postgresql.org>
Date:     Wed Nov 19 10:10:04 2014 +0000
First released in: 9.5.0, 9.4.0

    Fix bug in the test of file descriptor of current WAL file in pg_receivexlog.
    
    In pg_receivexlog, in order to check whether the current WAL file is
    being opened or not, its file descriptor has to be checked against -1
    as an invalid value. But, oops, 7900e94 added the incorrect test
    checking the descriptor against 1. This commit fixes that bug.
    
    Back-patch to 9.4 where the bug was added.
    
    Spotted by Magnus Hagander


 src/bin/pg_basebackup/receivelog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
index 1b8a5ad15ce..f0f8760e2db 100644
--- a/src/bin/pg_basebackup/receivelog.c
+++ b/src/bin/pg_basebackup/receivelog.c
@@ -1021,7 +1021,7 @@ ProcessKeepaliveMsg(PGconn *conn, char *copybuf, int len,
 	if (replyRequested && still_sending)
 	{
 		if (reportFlushPosition && lastFlushPosition < blockpos &&
-			walfile != 1)
+			walfile != -1)
 		{
 			/*
 			 * If a valid flush location needs to be reported,


[parent: f66c20b31757]