postgres.git / summary / log / commit / refs

commit    d65ecdf4110bb352527dd2f6de31421d5b769258
Author:   Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date:     Tue May 06 12:14:51 2014 +0000

    Fix use of free in walsender error handling after a sysid mismatch.
    
    Found via valgrind. The bug exists since the introduction of the walsender,
    so backpatch to 9.0.
    
    Andres Freund


 src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
index 8f1c592f48b..d2786fdf8b0 100644
--- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
+++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
@@ -133,6 +133,7 @@ libpqrcv_connect(char *conninfo, XLogRecPtr startpoint)
 			 GetSystemIdentifier());
 	if (strcmp(primary_sysid, standby_sysid) != 0)
 	{
+		primary_sysid = pstrdup(primary_sysid);
 		PQclear(res);
 		ereport(ERROR,
 				(errmsg("database system identifier differs between the primary and standby"),


[parent: 91c8c106faca]