postgres.git / summary / log / commit / refs

commit    d9ec8d1d7dc2bfaa7ae001c4319f6988a83dd486
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Mon Feb 17 23:40:02 2020 +0000
First released in: 13.0, 9.5.22, 9.6.18, 10.13, 11.8, 12.3

    Teach pg_dump to dump comments on RLS policy objects.
    
    This was unaccountably omitted in the original RLS patch.
    The SQL syntax is basically the same as for comments on triggers,
    so crib code from dumpTrigger().
    
    Per report from Marc Munro.  Back-patch to all supported branches.
    
    Discussion: https://postgr.es/m/1581889298.18009.15.camel@bloodnok.com


 src/bin/pg_dump/pg_dump.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index c9fcb0231dd..e7a12794b60 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -3157,6 +3157,8 @@ dumpPolicy(Archive *fout, PolicyInfo *polinfo)
 	TableInfo  *tbinfo = polinfo->poltable;
 	PQExpBuffer query;
 	PQExpBuffer delqry;
+	PQExpBuffer polprefix;
+	char	   *qtabname;
 	const char *cmd;
 
 	if (dopt->dataOnly)
@@ -3212,6 +3214,9 @@ dumpPolicy(Archive *fout, PolicyInfo *polinfo)
 
 	query = createPQExpBuffer();
 	delqry = createPQExpBuffer();
+	polprefix = createPQExpBuffer();
+
+	qtabname = pg_strdup(fmtId(tbinfo->dobj.name));
 
 	appendPQExpBuffer(query, "CREATE POLICY %s", fmtId(polinfo->polname));
 
@@ -3232,6 +3237,9 @@ dumpPolicy(Archive *fout, PolicyInfo *polinfo)
 	appendPQExpBuffer(delqry, "DROP POLICY %s", fmtId(polinfo->polname));
 	appendPQExpBuffer(delqry, " ON %s;\n", fmtQualifiedDumpable(tbinfo));
 
+	appendPQExpBuffer(polprefix, "POLICY %s ON",
+					  fmtId(polinfo->polname));
+
 	ArchiveEntry(fout, polinfo->dobj.catId, polinfo->dobj.dumpId,
 				 polinfo->dobj.name,
 				 polinfo->dobj.namespace->dobj.name,
@@ -3242,8 +3250,14 @@ dumpPolicy(Archive *fout, PolicyInfo *polinfo)
 				 NULL, 0,
 				 NULL, NULL);
 
+	dumpComment(fout, polprefix->data, qtabname,
+				tbinfo->dobj.namespace->dobj.name, tbinfo->rolname,
+				polinfo->dobj.catId, 0, polinfo->dobj.dumpId);
+
 	destroyPQExpBuffer(query);
 	destroyPQExpBuffer(delqry);
+	destroyPQExpBuffer(polprefix);
+	free(qtabname);
 }
 
 static void


[parent: 2b9d4ec1d3c0]