pgdog.git / summary / log / commit / refs

commit    da0524c27d4a4586533b69330f0af940bc1f7d22
Author:   Lev Kokotov <levkk@users.noreply.github.com>
Commit:   GitHub <noreply@github.com>
Date:     Wed May 27 00:07:26 2026 +0000

    fix: false positive OpenMetrics error in logs (#1008)
    
    fix #980 
    
    Basically clients close HTTP connections before sending a complete
    request. Happens all the time, we shouldn't be logging it as an error.


 pgdog/src/stats/http_server.rs | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/pgdog/src/stats/http_server.rs b/pgdog/src/stats/http_server.rs
index e67adcb7..c2f6c2e6 100644
--- a/pgdog/src/stats/http_server.rs
+++ b/pgdog/src/stats/http_server.rs
@@ -8,7 +8,7 @@ use hyper::service::service_fn;
 use hyper::{Request, Response};
 use hyper_util::rt::TokioIo;
 use tokio::net::TcpListener;
-use tracing::info;
+use tracing::{info, warn};
 
 use super::{Clients, MirrorStatsMetrics, Pools, QueryCache, TwoPc};
 
@@ -61,7 +61,13 @@ pub async fn server(port: u16) -> std::io::Result<()> {
                 .serve_connection(io, service_fn(metrics))
                 .await
             {
-                eprintln!("OpenMetrics endpoint error: {:?}", err);
+                // Clients (TCP health probes, scrapers that disconnect
+                // mid-request, keep-alive teardown) routinely close the socket
+                // before sending a complete request. That surfaces as
+                // IncompleteMessage and is benign.
+                if !err.is_incomplete_message() {
+                    warn!("OpenMetrics endpoint error: {:?}", err);
+                }
             }
         });
     }


[parent: c90a70649c48]