postgres.git / summary / log / commit / refs

commit    dab83a62fc62ecc3183314134d40b723eb4332cd
Author:   Andres Freund <andres@anarazel.de>
Date:     Tue Feb 04 22:45:57 2025 +0000
First released in: 18.0, 16.7, 17.3

    meson: Improve dependencies for tmp_install test target
    
    The missing dependency was, e.g., visible when doing
      ninja clean && ninja meson-test-prereq && meson test --no-rebuild --suite setup --suite cube
    because meson (and thus its internal meson-test-prereq target) did not know
    about a lot of the required targets.
    
    Previously tmp_install did not actually depend on the relevant files being
    built. That was mostly not visible, because "meson test" currently uses the
    'default' targets as a test's dependency if no dependency is specified.
    However, there are plans to narrow that on the meson side, to make it quicker
    to run tests.
    
    Apply this to all branches with meson support, as part of an effort to fix
    incorrect test dependencies that can lead to test failures.
    
    Discussion: https://postgr.es/m/CAGECzQSvM3iSDmjF+=Kof5an6jN8UbkP_4cKKT9w6GZavmb5yQ@mail.gmail.com
    Discussion: https://postgr.es/m/bdba588f-69a9-4f3e-9b95-62d07210a32e@eisentraut.org
    Backpatch: 16-, where meson support was added


 meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build
index cdfdbb79e88..0623799ee23 100644
--- a/meson.build
+++ b/meson.build
@@ -3190,6 +3190,7 @@ test('tmp_install',
     priority: setup_tests_priority,
     timeout: 300,
     is_parallel: false,
+    depends: installed_targets,
     suite: ['setup'])
 
 test('install_test_files',


[parent: 80620931053d]