postgres.git / summary / log / commit / refs

commit    dcd052c8d20c5359c55f2a101f10a8e6341233cd
Author:   Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date:     Wed Aug 16 21:48:44 2017 +0000

    Fix pg_atomic_u64 initialization.
    
    As Andres pointed out, pg_atomic_init_u64 must be used to initialize an
    atomic variable, before it can be accessed with the actual atomic ops.
    Trying to use pg_atomic_write_u64 on an uninitialized variable leads to a
    failure with the fallback implementation that uses a spinlock.
    
    Discussion: https://www.postgresql.org/message-id/20170816191346.d3ke5tpshhco4bnd%40alap3.anarazel.de


 src/backend/access/heap/heapam.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index 7dea8472c17..8792f1453cb 100644
--- a/src/backend/access/heap/heapam.c
+++ b/src/backend/access/heap/heapam.c
@@ -1638,7 +1638,7 @@ heap_parallelscan_initialize(ParallelHeapScanDesc target, Relation relation,
 		target->phs_nblocks > NBuffers / 4;
 	SpinLockInit(&target->phs_mutex);
 	target->phs_startblock = InvalidBlockNumber;
-	pg_atomic_write_u64(&target->phs_nallocated, 0);
+	pg_atomic_init_u64(&target->phs_nallocated, 0);
 	SerializeSnapshot(snapshot, target->phs_snapshot_data);
 }
 


[parent: ec0a69e49bf4]