postgres.git / summary / log / commit / refs

commit    dce507356a4ab7d548dca9d7abf1800a0fc0a18e
Author:   Alvaro Herrera <alvherre@alvh.no-ip.org>
Date:     Wed Sep 25 14:42:02 2024 +0000
First released in: 18.0

    Turn 'if' condition around to avoid Svace complaint
    
    The unwritten assumption of this code is that both events->head and
    events->tail are NULL together (an empty list) or they aren't.  So the
    code was testing events->head for nullness and using that as a cue to
    deference events->tail, which annoys the Svace static code analyzer.
    We can silence it by testing events->tail member instead, and add an
    assertion about events->head to ensure it's all consistent.
    
    This code is very old and as far as we know, there's never been a bug
    report related to this, so there's no need to backpatch.
    
    This was found by the ALT Linux Team using Svace.
    
    Author: Alexander Kuznetsov <kuznetsovam@altlinux.org>
    Discussion: https://postgr.es/m/6d0323c3-3f5d-4137-af73-98a5ab90e77c@altlinux.org


src/backend/commands/trigger.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c index 29d30bfb6f7..3671e82535e 100644 --- a/src/backend/commands/trigger.c +++ b/src/backend/commands/trigger.c @@ -4097,8 +4097,11 @@ afterTriggerAddEvent(AfterTriggerEventList *events, chunk->endptr = chunk->endfree = (char *) chunk + chunksize; Assert(chunk->endfree - chunk->freeptr >= needed); - if (events->head == NULL) + if (events->tail == NULL) + { + Assert(events->head == NULL); events->head = chunk; + } else events->tail->next = chunk; events->tail = chunk; [parent: 1ab67c9dfaad]