postgres.git / summary / log / commit / refs

commit    dd1daa03bc8e49f463f2d852f7afe6506f0bb612
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Mon May 29 19:19:07 2017 +0000

    Allow NumericOnly to be "+ FCONST".
    
    The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST,
    FCONST, and - FCONST, but for some reason not + FCONST.  This led to
    strange inconsistencies like
    
    regression=# set random_page_cost = +4;
    SET
    regression=# set random_page_cost = 4000000000;
    SET
    regression=# set random_page_cost = +4000000000;
    ERROR:  syntax error at or near "4000000000"
    
    (because 4000000000 is too large to be an ICONST).  While there's
    no actual functional reason to need to write a "+", if we allow
    it for integers it seems like we should allow it for numerics too.
    
    It's been like that forever, so back-patch to all supported branches.
    
    Discussion: https://postgr.es/m/30908.1496006184@sss.pgh.pa.us


 src/backend/parser/gram.y | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index ab189a3df2f..c080cf9ea08 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -3688,6 +3688,7 @@ opt_by:		BY				{}
 
 NumericOnly:
 			FCONST								{ $$ = makeFloat($1); }
+			| '+' FCONST						{ $$ = makeFloat($2); }
 			| '-' FCONST
 				{
 					$$ = makeFloat($2);


[parent: acab87ece1a4]