postgres.git / summary / log / commit / refs

commit    de8e46f5f5785f4016aabf2aa231faa89a0746fb
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Tue Dec 16 19:53:55 2014 +0000
First released in: 9.5.0, 9.4.1

    Suppress bogus statistics when pgbench failed to complete any transactions.
    
    Code added in 9.4 would attempt to divide by zero in such cases.
    Noted while testing fix for missing-pclose problem.


 contrib/pgbench/pgbench.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
index 397403f221c..d69036a2f5c 100644
--- a/contrib/pgbench/pgbench.c
+++ b/contrib/pgbench/pgbench.c
@@ -2541,6 +2541,10 @@ printResults(int ttype, int64 normal_xacts, int nclients,
 			   normal_xacts);
 	}
 
+	/* Remaining stats are nonsensical if we failed to execute any xacts */
+	if (normal_xacts <= 0)
+		return;
+
 	if (throttle_delay && latency_limit)
 		printf("number of transactions skipped: " INT64_FORMAT " (%.3f %%)\n",
 			   throttle_latency_skipped,


[parent: d38e8d30cece]