postgres.git / summary / log / commit / refs

commit    deb15803249883db031c6cc8af104b575f7809ad
Author:   Robert Haas <rhaas@postgresql.org>
Date:     Fri Oct 28 19:45:28 2011 +0000
First released in: 9.2.0

    Remove hard-coded "\connect postgres" from pg_dumpall.
    
    This doesn't appear to accompish anything useful, and does make the
    restore fail if the postgres database happens to have been dropped.


 src/bin/pg_dump/pg_dumpall.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
index 0022d2d74ef..d138da568ea 100644
--- a/src/bin/pg_dump/pg_dumpall.c
+++ b/src/bin/pg_dump/pg_dumpall.c
@@ -441,7 +441,12 @@ main(int argc, char *argv[])
 	if (verbose)
 		dumpTimestamp("Started on");
 
-	fprintf(OPF, "\\connect postgres\n\n");
+	/*
+	 * We used to emit \connect postgres here, but that served no purpose
+	 * other than to break things for installations without a postgres
+	 * database.  Everything we're restoring here is a global, so whichever
+	 * database we're connected to at the moment is fine.
+	 */
 
 	/* Replicate encoding and std_strings in output */
 	fprintf(OPF, "SET client_encoding = '%s';\n",


[parent: 74812624f263]