postgres.git / summary / log / commit / refs

commit    e027ee9902fa414d766c8dc2589c6a3d7aeaa53a
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Tue Jan 14 06:13:14 2025 +0000
First released in: 18.0, 13.19, 14.16, 15.11, 16.7, 17.3

    Fix potential integer overflow in bringetbitmap()
    
    This function expects an "int64" as result and stores the number of
    pages to add to the index scan bitmap as an "int", multiplying its final
    result by 10.  For a relation large enough, this can theoretically
    overflow if counting more than (INT32_MAX / 10) pages, knowing that the
    number of pages is upper-bounded by MaxBlockNumber.
    
    To avoid the overflow, this commit redefines "totalpages", used to
    calculate the result, to be an "int64" rather than an "int".
    
    Reported-by: Evgeniy Gorbanyov
    Author: James Hunter
    Discussion: https://www.postgresql.org/message-id/07704817-6fa0-460c-b1cf-cd18f7647041@basealt.ru
    Backpatch-through: 13


 src/backend/access/brin/brin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c
index 6467bed604a..92cb72ebba6 100644
--- a/src/backend/access/brin/brin.c
+++ b/src/backend/access/brin/brin.c
@@ -563,7 +563,7 @@ bringetbitmap(IndexScanDesc scan, TIDBitmap *tbm)
 	BrinOpaque *opaque;
 	BlockNumber nblocks;
 	BlockNumber heapBlk;
-	int			totalpages = 0;
+	int64		totalpages = 0;
 	FmgrInfo   *consistentFn;
 	MemoryContext oldcxt;
 	MemoryContext perRangeCxt;


[parent: dc24c9ad527f]