postgres.git / summary / log / commit / refs

commit    e14536f79ea7ab70f0566b2e85c164af6a333829
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Fri Jan 18 20:23:44 2019 +0000
First released in: master (reverted before release), REL_11_STABLE (reverted before release)
Reverted by: 93f80cc2d758 (in 11.2), f4593bd2ff03 (in 12.0)

    Fix under-quoted filename pattern in pgbench TAP test.
    
    Avoids issues if build directory's pathname contains regex
    metacharacters.
    
    Raúl Marín Rodríguez
    
    Discussion: https://postgr.es/m/CAM6_UM6dGdU39PKAC24T+HD9ouy0jLN9vH6163K8QEEzr__iZw@mail.gmail.com


 src/bin/pgbench/t/001_pgbench_with_server.pl | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/bin/pgbench/t/001_pgbench_with_server.pl b/src/bin/pgbench/t/001_pgbench_with_server.pl
index 6b3bcef25a1..af988a4e015 100644
--- a/src/bin/pgbench/t/001_pgbench_with_server.pl
+++ b/src/bin/pgbench/t/001_pgbench_with_server.pl
@@ -800,9 +800,10 @@ sub check_pgbench_logs
 {
 	my ($prefix, $nb, $min, $max, $re) = @_;
 
-	my @logs = glob "$prefix.*";
+	my $qprefix = quotemeta($prefix);
+	my @logs = glob "$qprefix.*";
 	ok(@logs == $nb, "number of log files");
-	ok(grep(/^$prefix\.\d+(\.\d+)?$/, @logs) == $nb, "file name format");
+	ok(grep(/^$qprefix\.\d+(\.\d+)?$/, @logs) == $nb, "file name format");
 
 	my $log_number = 0;
 	for my $log (sort @logs)


[parent: e4ffa0dcb797]