postgres.git / summary / log / commit / refs

commit    e158bbb6e95afde040debf3f573fc9b60dbcf469
Author:   Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date:     Mon May 12 07:17:40 2014 +0000
First released in: 9.4.0, 9.2.9, 9.3.5

    Free PQresult on error in pg_receivexlog.
    
    The leak is fairly small and rare, but a leak nevertheless.
    
    Per Coverity report. Backpatch to 9.2, where pg_receivexlog was added.
    pg_basebackup shares the code, but it always exits on error, so there is
    no real leak.


 src/bin/pg_basebackup/receivelog.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
index a7a79e824a3..3a46767417e 100644
--- a/src/bin/pg_basebackup/receivelog.c
+++ b/src/bin/pg_basebackup/receivelog.c
@@ -612,6 +612,7 @@ ReceiveXlogStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,
 		fprintf(stderr,
 				_("%s: unexpected termination of replication stream: %s"),
 				progname, PQresultErrorMessage(res));
+		PQclear(res);
 		goto error;
 	}
 	PQclear(res);


[parent: 9bc1b439ef8b]