postgres.git / summary / log / commit / refs

commit    e2e3b8ae9ed73fcd3096c5ca93971891a7767388
Author:   Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date:     Fri Mar 15 11:06:57 2024 +0000
First released in: 17.0

    Disable tests using injection points in installcheck
    
    The 'gin' test injections faults to GIN index build. If another test
    running concurrently in the same cluster also tries to create a GIN
    index, it will hit the fault, too.
    
    To fix, disable tests using injection points when running against an
    existing cluster. A better long-term solution would be to make the
    injection points scoped to the database or process, but this will do
    for now.
    
    Discussion: https://www.postgresql.org/message-id/CA%2BhUKGJYhcG_o2nwSK6r01eOZJwNWUJUbX%3D%3DAVnW84f-%2B8yamQ@mail.gmail.com
    Discussion: https://www.postgresql.org/message-id/10fd6cdd-c5d9-46fe-9fa1-7e661191309e@iki.fi


 src/test/modules/gin/Makefile                 | 3 +++
 src/test/modules/gin/meson.build              | 2 ++
 src/test/modules/injection_points/Makefile    | 3 +++
 src/test/modules/injection_points/meson.build | 2 ++
 4 files changed, 10 insertions(+)

diff --git a/src/test/modules/gin/Makefile b/src/test/modules/gin/Makefile
index a7731b7fa18..81ca6bfe35a 100644
--- a/src/test/modules/gin/Makefile
+++ b/src/test/modules/gin/Makefile
@@ -4,6 +4,9 @@ EXTRA_INSTALL = src/test/modules/injection_points
 
 REGRESS = gin_incomplete_splits
 
+# The injection points are cluster-wide, so disable installcheck
+NO_INSTALLCHECK = 1
+
 ifdef USE_PGXS
 PG_CONFIG = pg_config
 PGXS := $(shell $(PG_CONFIG) --pgxs)
diff --git a/src/test/modules/gin/meson.build b/src/test/modules/gin/meson.build
index 9734b51de2d..5ec0760a276 100644
--- a/src/test/modules/gin/meson.build
+++ b/src/test/modules/gin/meson.build
@@ -12,5 +12,7 @@ tests += {
     'sql': [
       'gin_incomplete_splits',
     ],
+    # The injection points are cluster-wide, so disable installcheck
+    'runningcheck': false,
   },
 }
diff --git a/src/test/modules/injection_points/Makefile b/src/test/modules/injection_points/Makefile
index 2cbbae4e0a0..4248671513a 100644
--- a/src/test/modules/injection_points/Makefile
+++ b/src/test/modules/injection_points/Makefile
@@ -8,6 +8,9 @@ PGFILEDESC = "injection_points - facility for injection points"
 
 REGRESS = injection_points
 
+# The injection points are cluster-wide, so disable installcheck
+NO_INSTALLCHECK = 1
+
 ifdef USE_PGXS
 PG_CONFIG = pg_config
 PGXS := $(shell $(PG_CONFIG) --pgxs)
diff --git a/src/test/modules/injection_points/meson.build b/src/test/modules/injection_points/meson.build
index ee37573f2ab..a29217f75f9 100644
--- a/src/test/modules/injection_points/meson.build
+++ b/src/test/modules/injection_points/meson.build
@@ -33,5 +33,7 @@ tests += {
     'sql': [
       'injection_points',
     ],
+    # The injection points are cluster-wide, so disable installcheck
+    'runningcheck': false,
   },
 }


[parent: 071e3ad59d6f]