pgpool2.git / summary / log / commit / refs

commit    e5793bcdd3ba44ae6c58008c7fb671103501c129
Author:   Tatsuo Ishii <ishii@postgresql.org>
Commit:   Muhammad Usama <m.usama@gmail.com>
Date:     Fri Nov 22 11:24:35 2013 +0000

    Fix read_kind_from_backend() possible segfault when all backend down.
    
    Per Coverity report 1111414 "Negative array index read".


 src/protocol/pool_process_query.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/protocol/pool_process_query.c b/src/protocol/pool_process_query.c
index a6acdeee8..acb0e6ab0 100644
--- a/src/protocol/pool_process_query.c
+++ b/src/protocol/pool_process_query.c
@@ -3863,6 +3863,11 @@ POOL_STATUS read_kind_from_backend(POOL_CONNECTION *frontend, POOL_CONNECTION_PO
 			}
 		}
 	}
+	else if (first_node == -1)
+	{
+		pool_error("read_kind_from_backend: couldn't find first node. All backend down?");
+		return POOL_ERROR;
+	}
 	else
 		trust_kind = kind_list[first_node];
 


[parent: 9e9ae9160a0c]