supabase-postgres.git / summary / log / commit / refs

commit    e796aad40a46f0f9898f0ff85ed8b592698c4d3d
Author:   Bobbie Soedirgo <bobbie@soedirgo.dev>
Commit:   Bobbie Soedirgo <31685197+soedirgo@users.noreply.github.com>
Date:     Wed Jun 26 05:16:46 2024 +0000

    feat: grant predefined roles to postgres
    
    Decouples some changes from
    https://github.com/supabase/postgres/pull/994/files
    
    `postgres` can already grant these roles to itself; granting these by
    default removes one step if users need to read Storage migrations, kill
    running queries from non-superusers, etc.


 .../migrations/20240606060239_grant_predefined_roles_to_postgres.sql | 4 ++++
 migrations/tests/database/privs.sql                                  | 5 ++++-
 migrations/tests/test.sql                                            | 2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/migrations/db/migrations/20240606060239_grant_predefined_roles_to_postgres.sql b/migrations/db/migrations/20240606060239_grant_predefined_roles_to_postgres.sql
new file mode 100644
index 00000000..324e1241
--- /dev/null
+++ b/migrations/db/migrations/20240606060239_grant_predefined_roles_to_postgres.sql
@@ -0,0 +1,4 @@
+-- migrate:up
+grant pg_read_all_data, pg_signal_backend to postgres;
+
+-- migrate:down
diff --git a/migrations/tests/database/privs.sql b/migrations/tests/database/privs.sql
index 217da662..d164e0cb 100644
--- a/migrations/tests/database/privs.sql
+++ b/migrations/tests/database/privs.sql
@@ -1,4 +1,3 @@
-
 SELECT database_privs_are(
     'postgres', 'postgres', ARRAY['CONNECT', 'TEMPORARY', 'CREATE']
 );
@@ -28,3 +27,7 @@ SELECT schema_privs_are('extensions', 'postgres', array['CREATE', 'USAGE']);
 SELECT schema_privs_are('extensions', 'anon', array['USAGE']);
 SELECT schema_privs_are('extensions', 'authenticated', array['USAGE']);
 SELECT schema_privs_are('extensions', 'service_role', array['USAGE']);
+
+-- Role memberships
+SELECT is_member_of('pg_read_all_data', 'postgres');
+SELECT is_member_of('pg_signal_backend', 'postgres');
diff --git a/migrations/tests/test.sql b/migrations/tests/test.sql
index 6bd7f23a..7afa4064 100644
--- a/migrations/tests/test.sql
+++ b/migrations/tests/test.sql
@@ -5,7 +5,7 @@ BEGIN;
 
 CREATE EXTENSION IF NOT EXISTS pgtap;
 
-SELECT plan(34);
+SELECT no_plan();
 
 \ir fixtures.sql
 \ir database/test.sql


[parent: 53764b3dcec9]