pgpool2.git / summary / log / commit / refs

commit    e7b0d860b6e9d2e066ab4e24448604b83f68a482
Author:   Muhammad Usama <m.usama@highgo.ca>
Commit:   Muhammad Usama <m.usama@gmail.com>
Date:     Tue Sep 08 08:21:03 2020 +0000

    Fix for coverity issue CID:1430581 Resource leak


 src/config/pool_config_variables.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/config/pool_config_variables.c b/src/config/pool_config_variables.c
index 976043646..12cb6a2bd 100644
--- a/src/config/pool_config_variables.c
+++ b/src/config/pool_config_variables.c
@@ -4748,7 +4748,7 @@ MakeDMLAdaptiveObjectRelationList(char *newval, int elevel)
 
 	for (i = 0; i < elements_count; i++)
 	{
-		char *kvstr = pstrdup(rawList[i]);
+		char *kvstr = rawList[i];
 		char *left_token = strtok(kvstr, ":");
 		char *right_token = strtok(NULL, ":");
 		DBObjectTypes object_type;
@@ -4770,6 +4770,8 @@ MakeDMLAdaptiveObjectRelationList(char *newval, int elevel)
 	pool_config->parsed_dml_adaptive_object_relationship_list[i].left_token.object_type = OBJECT_TYPE_UNKNOWN;
 	pool_config->parsed_dml_adaptive_object_relationship_list[i].right_token.name = NULL;
 	pool_config->parsed_dml_adaptive_object_relationship_list[i].right_token.object_type = OBJECT_TYPE_UNKNOWN;
+
+	pfree(rawList);
 	return true;
 }
 


[parent: e4abeb7ddbbd]