postgresql-jdbc.git / summary / log / commit / refs

commit    e975c07ceecea4d2aee457e56a6964bc4203fdba
Author:   Dave Cramer <davecramer@gmail.com>
Date:     Tue Nov 10 16:36:57 2015 +0000

    fix test case to actually check the value
    don't mask the exception in the event that it is thrown


 org/postgresql/test/jdbc2/ArrayTest.java | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/org/postgresql/test/jdbc2/ArrayTest.java b/org/postgresql/test/jdbc2/ArrayTest.java
index 6753dfa5..7e9d7d27 100644
--- a/org/postgresql/test/jdbc2/ArrayTest.java
+++ b/org/postgresql/test/jdbc2/ArrayTest.java
@@ -413,6 +413,7 @@ public class ArrayTest extends TestCase
 
         assertTrue(!arrRS.next());
     }
+    
     public void testEmptyBinaryArray() throws SQLException
     {
         
@@ -421,19 +422,13 @@ public class ArrayTest extends TestCase
         ((org.postgresql.PGStatement)pstmt).setPrepareThreshold(-1);
         
         ResultSet rs = pstmt.executeQuery();
+ 
         while (rs.next()) {
             Array array = rs.getArray(1);
             if (!rs.wasNull())
             {
                 ResultSet ars  = array.getResultSet();
-                try
-                {
-                    ars.getMetaData().getColumnType(1); // this throws NPE
-                }
-                catch (NullPointerException ex)
-                {
-                    assertTrue("should not get here",true);
-                }
+                assertEquals(java.sql.Types.INTEGER,ars.getMetaData().getColumnType(1)); 
             }
 
         }


[parent: 9133012e1e67]