postgres.git / summary / log / commit / refs

commit    e9d4cbeacb553fc5f4c185ec1156018ea4114fdd
Author:   Noah Misch <noah@leadboat.com>
Date:     Thu Apr 04 06:23:35 2019 +0000
First released in: master (reverted before release), REL9_4_STABLE (reverted before release), REL9_5_STABLE (reverted before release), REL9_6_STABLE (reverted before release), REL_10_STABLE (reverted before release), REL_11_STABLE (reverted before release)
Reverted by: 0777696fe346 (in 9.4.22), 9ec582b64d69 (in 9.5.17), ae98c24fda4b (in 9.6.13), 7d18a55c90eb (in 10.8), 392ea22e9b32 (in 11.3), 82150a05be0d (in 12.0)

    Silence -Wimplicit-fallthrough in sysv_shmem.c.
    
    Commit 2f932f71d9f2963bbd201129d7b971c8f5f077fd added code that elicits
    a warning on buildfarm member flaviventris.  Back-patch to 9.4, like
    that commit.
    
    Reported by Andres Freund.
    
    Discussion: https://postgr.es/m/20190404020057.galelv7by75ekqrh@alap3.anarazel.de


 src/backend/port/sysv_shmem.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/backend/port/sysv_shmem.c b/src/backend/port/sysv_shmem.c
index c05a4b409a2..69f9c63b9dc 100644
--- a/src/backend/port/sysv_shmem.c
+++ b/src/backend/port/sysv_shmem.c
@@ -676,6 +676,7 @@ PGSharedMemoryCreate(Size size, int port,
 								(unsigned long) shmid),
 						 errhint("Terminate any old server processes associated with data directory \"%s\".",
 								 DataDir)));
+				break;
 			case SHMSTATE_ENOENT:
 
 				/*
@@ -707,6 +708,7 @@ PGSharedMemoryCreate(Size size, int port,
 					dsm_cleanup_using_control_segment(oldhdr->dsm_control);
 				if (shmctl(shmid, IPC_RMID, NULL) < 0)
 					NextShmemSegID++;
+				break;
 		}
 
 		if (oldhdr && shmdt(oldhdr) < 0)


[parent: 3186d5fac55b]