pgdog.git / summary / log / commit / refs

commit    ea230b82786f3f5e2abe2b1acc71ced451b294ad
Author:   Lev Kokotov <lev.kokotov@gmail.com>
Date:     Thu Jan 09 22:19:04 2025 +0000

    clippy


 pgdog/src/backend/pool/inner.rs    | 2 +-
 pgdog/src/backend/pool/test/mod.rs | 6 ++----
 pgdog/src/frontend/comms.rs        | 6 ++++++
 pgdog/src/frontend/router/mod.rs   | 2 +-
 pgdog/src/net/messages/bind.rs     | 6 +++---
 5 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/pgdog/src/backend/pool/inner.rs b/pgdog/src/backend/pool/inner.rs
index 468011bc..3701306f 100644
--- a/pgdog/src/backend/pool/inner.rs
+++ b/pgdog/src/backend/pool/inner.rs
@@ -311,7 +311,7 @@ mod test {
         assert_eq!(inner.checked_out(), 0);
         inner.taken.push(Mapping {
             client: BackendKeyData::new(),
-            server: server.id().clone(),
+            server: *server.id(),
         });
         assert_eq!(inner.checked_out(), 1);
 
diff --git a/pgdog/src/backend/pool/test/mod.rs b/pgdog/src/backend/pool/test/mod.rs
index f9cf6e26..bcfe0536 100644
--- a/pgdog/src/backend/pool/test/mod.rs
+++ b/pgdog/src/backend/pool/test/mod.rs
@@ -18,7 +18,7 @@ fn pool() -> Pool {
     config.max = 1;
     config.min = 1;
 
-    let pool = Pool::new(PoolConfig {
+    Pool::new(PoolConfig {
         address: Address {
             host: "127.0.0.1".into(),
             port: 5432,
@@ -27,9 +27,7 @@ fn pool() -> Pool {
             password: "pgdog".into(),
         },
         config,
-    });
-
-    pool
+    })
 }
 
 #[tokio::test(flavor = "current_thread")]
diff --git a/pgdog/src/frontend/comms.rs b/pgdog/src/frontend/comms.rs
index 8dce9f86..40d6c2ab 100644
--- a/pgdog/src/frontend/comms.rs
+++ b/pgdog/src/frontend/comms.rs
@@ -27,6 +27,12 @@ pub struct Comms {
     id: Option<BackendKeyData>,
 }
 
+impl Default for Comms {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl Comms {
     /// Create new communications channel between a client and pgDog.
     pub fn new() -> Self {
diff --git a/pgdog/src/frontend/router/mod.rs b/pgdog/src/frontend/router/mod.rs
index 9b5ebb44..bb988135 100644
--- a/pgdog/src/frontend/router/mod.rs
+++ b/pgdog/src/frontend/router/mod.rs
@@ -58,7 +58,7 @@ impl Router {
 
         // SAFETY: deallocated below.
         let config = unsafe { cluster.plugin_config()? };
-        let input = Input::new(config, RoutingInput::query(query.into()));
+        let input = Input::new(config, RoutingInput::query(query));
 
         let now = Instant::now();
 
diff --git a/pgdog/src/net/messages/bind.rs b/pgdog/src/net/messages/bind.rs
index c80b92f8..863e40f1 100644
--- a/pgdog/src/net/messages/bind.rs
+++ b/pgdog/src/net/messages/bind.rs
@@ -14,9 +14,9 @@ pub enum Format {
     Binary,
 }
 
-impl Into<i16> for Format {
-    fn into(self) -> i16 {
-        match self {
+impl From<Format> for i16 {
+    fn from(val: Format) -> Self {
+        match val {
             Format::Text => 0,
             Format::Binary => 1,
         }


[parent: 2164873e0e23]